Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lib.html to allow for horizontal forms in Bootstrap 4 #2368

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mdanse
Copy link
Contributor

@mdanse mdanse commented Jul 8, 2023

Use the FLASK_ADMIN_FORM_HORIZONTAL setting to control using vertical (default) or horizontal forms.

Use the FLASK_ADMIN_FORM_HORIZONTAL setting to control using vertical (default) or horizontal forms.
@samuelhwilliams
Copy link
Contributor

Happy to accept this kind of PR in principle.

Flask-Admin now has a Theme config object that replaces the need for environment variables like FLASK_ADMIN_FORM_HORIZONTAL. If this is possible for all Bootstrap versions, please can you add it to the base class and add support everywhere?

If it's only available for BS4, please create a new Bootstrap4Theme class and add it only to that.

It might be that should we should just deprecate Bootstrap2Theme and Bootstrap3Theme soon, but haven't made that call yet...

Copy link
Contributor

@princerb princerb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[this message was deleted]

@samuelhwilliams
Copy link
Contributor

??? Will it?

@princerb
Copy link
Contributor

??? Will it?

Oh, sorry, that was a mistake. I saw it like it was Bs3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants